Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0030] - Linux event model (Stage-2) #1779

Merged
merged 15 commits into from
Mar 5, 2022

Conversation

mitodrummer
Copy link
Contributor

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? n/a
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. yes
  • Have you added an entry to the CHANGELOG.next.md? not yet.

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content and examples look great! There are some markdown issues, and I noted a few grammar nits.

Stage 2 criteria:

  • Opened pull request for this draft revising the existing proposal
  • Completed field definitions
  • Included a real-world example source document
  • Identifies scope of impact of changes to ingestion mechanisms (e.g. beats/logstash), usage mechanisms (e.g. Kibana applications, detections), and the ECS project (e.g. docs, tooling)
  • Subject matter experts weighed in on the technical utility of field definitions in the pull request

@mitodrummer
Copy link
Contributor Author

Content and examples look great! There are some markdown issues, and I noted a few grammar nits.

Stage 2 criteria:

  • Opened pull request for this draft revising the existing proposal
  • Completed field definitions
  • Included a real-world example source document
  • Identifies scope of impact of changes to ingestion mechanisms (e.g. beats/logstash), usage mechanisms (e.g. Kibana applications, detections), and the ECS project (e.g. docs, tooling)
  • Subject matter experts weighed in on the technical utility of field definitions in the pull request

Calling all subject matter experts @norrietaylor @m-sample @ferullo @mattnite @rhysre

@mattnite
Copy link

I've gone over this RFC a number of times during it's development, there are some fields in here that we're not implementing for AWP's first milestone but everything defined is implementable and useful for capturing linux process information.

Copy link

@m-sample m-sample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@mitodrummer mitodrummer requested review from ebeahan and kgeller March 3, 2022 23:18
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just one house keeping note, we'll want to make sure we add this PR to the list when we update the stage and date before merge.

@m-sample
Copy link

m-sample commented Mar 4, 2022

@kgeller @ebeahan - is there something we need to do to kick the CLA check? Karl is on PTO today.

@mitodrummer mitodrummer merged commit b33d1fc into elastic:main Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants