-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0030] - Linux event model (Stage-2) #1779
[RFC 0030] - Linux event model (Stage-2) #1779
Conversation
17e7d33
to
89143dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content and examples look great! There are some markdown issues, and I noted a few grammar nits.
Stage 2 criteria:
- Opened pull request for this draft revising the existing proposal
- Completed field definitions
- Included a real-world example source document
- Identifies scope of impact of changes to ingestion mechanisms (e.g. beats/logstash), usage mechanisms (e.g. Kibana applications, detections), and the ECS project (e.g. docs, tooling)
- Subject matter experts weighed in on the technical utility of field definitions in the pull request
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Calling all subject matter experts @norrietaylor @m-sample @ferullo @mattnite @rhysre |
I've gone over this RFC a number of times during it's development, there are some fields in here that we're not implementing for AWP's first milestone but everything defined is implementable and useful for capturing linux process information. |
…s into stage-2-linux-event-model
…s into stage-2-linux-event-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just one house keeping note, we'll want to make sure we add this PR to the list when we update the stage and date before merge.
make test
? n/amake
and committed those changes? n/a