Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional log.syslog fields #1793

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

taylor-swanson
Copy link
Contributor

  • Add additional fields for RFC 5424 messages (log.syslog.version,
    log.syslog.msgid, log.syslog.data)
  • Add log.syslog.hostname, log.syslog.appname, and log.syslog.procid
    for hostname, process name, and process ID fields present in syslog
    messages, respectively. These fields are added since it is not always
    known that user wants these values copied to the more general ECS fields
    (host.hostname, process.name, process.pid).

- Add additional fields for RFC 5424 messages (log.syslog.version,
log.syslog.msgid, log.syslog.data)
- Add log.syslog.hostname, log.syslog.appname, and log.syslog.procid
for hostname, process name, and process ID fields present in syslog
messages, respectively. These fields are added since it is not always
known that user wants these values copied to the more general ECS fields
(host.hostname, process.name, process.pid).
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the adjustments.

Should these changes go into 8.2?

@taylor-swanson
Copy link
Contributor Author

LGTM! Thanks for making the adjustments.

Should these changes go into 8.2?

If we could do that, that would be great! The associated syslog parser/processor is also targeting 8.2.

@taylor-swanson taylor-swanson merged commit e7f66e2 into elastic:main Mar 1, 2022
@taylor-swanson taylor-swanson deleted the log-syslog-fields branch March 1, 2022 18:41
kgeller pushed a commit to kgeller/ecs that referenced this pull request Mar 1, 2022
- Add additional fields for RFC 5424 messages (log.syslog.version,
log.syslog.msgid, log.syslog.data)
- Add log.syslog.hostname, log.syslog.appname, and log.syslog.procid
for hostname, process name, and process ID fields present in syslog
messages, respectively. These fields are added since it is not always
known that user wants these values copied to the more general ECS fields
(host.hostname, process.name, process.pid).
- Updating changelog entry to 8.2

Co-authored-by: Kylie Geller <[email protected]>
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
kgeller added a commit that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants