Added id, name and version fields for faas
#1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWert
changed the title
faas.id and faas.name fieldsid, name and version fields for faas
kgeller
requested changes
Mar 1, 2022
There was a problem hiding this comment.
@AlexanderWert I think these changes make sense. Could you update the RFC as well to reflect these additions since faas.* is still stage 2 / beta?
|
Thanks @kgeller ! I updated the RFC. |
kgeller
pushed a commit
to kgeller/ecs
that referenced
this pull request
Mar 2, 2022
* Added faas.id and faas.name fields. * generated new artifacts with updated faas fields * updated changelog * added faas.version * updated faas RFC Co-authored-by: Kylie Geller <[email protected]> # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
This was referenced Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned from customer feedback that in some scenarios it's reasonable to map multiple serverless functions (e.g. AWS Lambda functions) to one single service entity within Elastic. Therefore, we cannot rely on the
service.name,service.versionandservice.idfields to represent the serverless function name and serverless function id.Thus, additional
faasfields are needed to explicitly capture capture the function id and name.This PR adds the
faas.id,faas.nameandfaas.versionfields to ECSfaasfields group.