Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTI addendum threat.feed.name, threat.feed.dashboard_id #1844

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

ecezalp
Copy link
Contributor

@ecezalp ecezalp commented Mar 18, 2022

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? yes
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? yes
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. yes
  • Have you added an entry to the CHANGELOG.next.md? yes

@ecezalp ecezalp added the 8.2.0 label Mar 18, 2022
@ecezalp ecezalp self-assigned this Mar 18, 2022
@ecezalp ecezalp requested review from peasead, ebeahan and rylnd March 18, 2022 18:48
Co-authored-by: Andrew Pease <[email protected]>
Copy link
Contributor

@peasead peasead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field additions look good to me!

CI is failing because there's several files that need updated each time the schema's updated.

If you run make from the top-level of the repo, it'll auto-generate all the necessary changes. After running make, add and commit the updates artifacts/docs and push the changes. This should make CI go ✅.

Finally, can you add a CHANGELOG.next entry under the 8.2 header: https://github.com/elastic/ecs/blob/main/CHANGELOG.next.md#820-soft-feature-freeze? Though 8.2 is under soft FF, there's no issue adding these fields.

@ecezalp ecezalp requested a review from ebeahan March 23, 2022 14:48
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ecezalp ecezalp merged commit a3f0fb3 into elastic:main Mar 23, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Mar 23, 2022
Co-authored-by: Ece Ozalp <[email protected]>
Co-authored-by: Andrew Pease <[email protected]>
(cherry picked from commit a3f0fb3)

# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@ebeahan
Copy link
Member

ebeahan commented Mar 23, 2022

💚 All backports created successfully

Status Branch Result
8.2

Questions ?

Please refer to the Backport tool documentation

ecezalp added a commit that referenced this pull request Mar 23, 2022
Co-authored-by: Ece Ozalp <[email protected]>
Co-authored-by: Andrew Pease <[email protected]>
(cherry picked from commit a3f0fb3)

# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv

Co-authored-by: Ece Özalp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants