-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTI addendum threat.feed.name, threat.feed.dashboard_id #1844
Conversation
c5b7f34
to
01386bd
Compare
92f3662
to
d292cc6
Compare
d292cc6
to
24f26c0
Compare
Co-authored-by: Andrew Pease <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field additions look good to me!
CI is failing because there's several files that need updated each time the schema's updated.
If you run make
from the top-level of the repo, it'll auto-generate all the necessary changes. After running make
, add and commit the updates artifacts/docs and push the changes. This should make CI go ✅.
Finally, can you add a CHANGELOG.next entry under the 8.2 header: https://github.com/elastic/ecs/blob/main/CHANGELOG.next.md#820-soft-feature-freeze? Though 8.2 is under soft FF, there's no issue adding these fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-authored-by: Ece Ozalp <[email protected]> Co-authored-by: Andrew Pease <[email protected]> (cherry picked from commit a3f0fb3) # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Co-authored-by: Ece Ozalp <[email protected]> Co-authored-by: Andrew Pease <[email protected]> (cherry picked from commit a3f0fb3) # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv Co-authored-by: Ece Özalp <[email protected]>
make test
? yesmake
and committed those changes? yes