Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Include constraints for process.env_vars object field #1884

Merged
merged 4 commits into from
Apr 20, 2022
Merged

[DOCS] Include constraints for process.env_vars object field #1884

merged 4 commits into from
Apr 20, 2022

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Apr 18, 2022

Note process.env_vars should not contain nested objects and use keyword for all field values.

These conventions are the same as the label field.

@ebeahan ebeahan requested a review from a team as a code owner April 18, 2022 20:46
@ebeahan ebeahan merged commit a20edfc into elastic:main Apr 20, 2022
@ebeahan ebeahan deleted the note-keyword-env-vars branch April 20, 2022 19:53
ebeahan added a commit to ebeahan/ecs that referenced this pull request Apr 20, 2022
@ebeahan
[DOCS] Include constraints for process.env_vars object field (elast…
89a10a2 
…ic#1884)

* provide type and nested guidance

* artifacts

* add PR to changelog entry

(cherry picked from commit a20edfc)
@ebeahan ebeahan mentioned this pull request Apr 20, 2022
Merged
ebeahan added a commit to ebeahan/ecs that referenced this pull request Apr 20, 2022
@ebeahan
[DOCS] Include constraints for process.env_vars object field (elast…
c99998e 
…ic#1884)

* provide type and nested guidance

* artifacts

* add PR to changelog entry

(cherry picked from commit a20edfc)
@ebeahan ebeahan mentioned this pull request Apr 20, 2022
Merged
@ebeahan
Copy link
Member Author

ebeahan commented Apr 20, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.3
✅ 8.2

Questions ?

Please refer to the Backport tool documentation

ebeahan added a commit that referenced this pull request Apr 20, 2022
@ebeahan
[DOCS] Include constraints for process.env_vars object field (#1884) (
304442f 
#1887)

* provide type and nested guidance

* artifacts

* add PR to changelog entry

(cherry picked from commit a20edfc)
ebeahan added a commit that referenced this pull request Apr 20, 2022
@ebeahan
[DOCS] Include constraints for process.env_vars object field (#1884) (
48a1eb7 
#1888)

* provide type and nested guidance

* artifacts

* add PR to changelog entry

(cherry picked from commit a20edfc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

Assignees
No one assigned
Labels
8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebeahan @kgeller