Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding missing process fields #1906

Merged
merged 9 commits into from
May 23, 2022

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented May 9, 2022

Resolves #1902

Adding two process fields to the top-level so that their details show in the documentation

See updated docs https://ecs_1906.docs-preview.app.elstc.co/guide/en/ecs/master/ecs-process.html

@kgeller kgeller self-assigned this May 9, 2022
@kgeller kgeller added the 8.2.1 label May 9, 2022
@kgeller kgeller marked this pull request as ready for review May 9, 2022 14:06
@kgeller kgeller requested a review from a team as a code owner May 9, 2022 14:06
@kgeller kgeller requested a review from mitodrummer May 9, 2022 14:06
@ebeahan ebeahan mentioned this pull request May 10, 2022
@ebeahan
Copy link
Member

ebeahan commented May 17, 2022

Updated PR to use the docs_only attribute.

@ebeahan ebeahan requested a review from a team May 20, 2022 18:01
@ebeahan ebeahan merged commit 905da40 into elastic:main May 23, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request May 23, 2022
* adding process fields for missing docs

* artifacts

* adding extra note for clarity and parity

* artifacts again

* changelog entry

* add docs_only: true param

* regenerate artifacts

Co-authored-by: Eric Beahan <[email protected]>
(cherry picked from commit 905da40)
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request May 23, 2022
* adding process fields for missing docs

* artifacts

* adding extra note for clarity and parity

* artifacts again

* changelog entry

* add docs_only: true param

* regenerate artifacts

Co-authored-by: Eric Beahan <[email protected]>
(cherry picked from commit 905da40)
@ebeahan
Copy link
Member

ebeahan commented May 23, 2022

💚 All backports created successfully

Status Branch Result
8.3
8.2

Questions ?

Please refer to the Backport tool documentation

ebeahan added a commit that referenced this pull request May 23, 2022
* adding process fields for missing docs

* artifacts

* adding extra note for clarity and parity

* artifacts again

* changelog entry

* add docs_only: true param

* regenerate artifacts

Co-authored-by: Eric Beahan <[email protected]>
(cherry picked from commit 905da40)

Co-authored-by: Kylie Geller <[email protected]>
ebeahan added a commit that referenced this pull request May 23, 2022
* adding process fields for missing docs

* artifacts

* adding extra note for clarity and parity

* artifacts again

* changelog entry

* add docs_only: true param

* regenerate artifacts

Co-authored-by: Eric Beahan <[email protected]>
(cherry picked from commit 905da40)

Co-authored-by: Kylie Geller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The process.same_as_process boolean field does not show up in the ecs documentation.
5 participants