-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "docs_only" attribute for subsets #1909
Conversation
With the refactoring, I've removed these entries. We can handle it in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* add docs_only_fields * first pass at apply docs_only to subset filter config * linting * update field details * handle case with no docs_only fields declared * removed defining docs_only fields here * cleanup * add new unit tests * document in usage * revert changes to beats generator and default_fields list * extra import * changelog * moving entry (cherry picked from commit 9ca4cf3)
* add docs_only_fields * first pass at apply docs_only to subset filter config * linting * update field details * handle case with no docs_only fields declared * removed defining docs_only fields here * cleanup * add new unit tests * document in usage * revert changes to beats generator and default_fields list * extra import * changelog * moving entry (cherry picked from commit 9ca4cf3) # Conflicts: # CHANGELOG.next.md
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* add docs_only_fields * first pass at apply docs_only to subset filter config * linting * update field details * handle case with no docs_only fields declared * removed defining docs_only fields here * cleanup * add new unit tests * document in usage * revert changes to beats generator and default_fields list * extra import * changelog * moving entry (cherry picked from commit 9ca4cf3)
* add docs_only_fields * first pass at apply docs_only to subset filter config * linting * update field details * handle case with no docs_only fields declared * removed defining docs_only fields here * cleanup * add new unit tests * document in usage * revert changes to beats generator and default_fields list * extra import * changelog * moving entry (cherry picked from commit 9ca4cf3)
Overview
Introduce a new attribute for subset file definitions,
docs_only.
Settingdocs_only: True
only filters the field to include it in the ECS docs.Example usage
Use case
Support for situations like the
process.same_as_parent
field, which is only populated inprocess
reuses. In the current documentation, a field still must be defined and described at the top level. The field's description includes the guidance of which reuses contains the field.Design
The changes to support
docs_only
were added toschema.subset_filter
. Ifdocs_only
is defined on any subset fields, these extra steps take place:docs_only
fields is createddocs_only
fields using this second subsetdocs_only
fields from the main fields list. Removing the fields prevents them from appearing in any other artifacts.ascii_doc
generator alongside the main fields.Resolves #1907