Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA threat.enrichments.indicator #1928

Merged
merged 9 commits into from
Jul 19, 2022
Merged

GA threat.enrichments.indicator #1928

merged 9 commits into from
Jul 19, 2022

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented May 23, 2022

The RFCs for threat enrichment have been stage 3 for some time now(see 0021 and 0008), so this PR finally advances the rest of the threat.enrichments.indicator fields and re-uses to GA.

@kgeller kgeller self-assigned this May 23, 2022
@kgeller kgeller marked this pull request as ready for review May 23, 2022 17:33
@kgeller kgeller requested a review from a team as a code owner May 23, 2022 17:33
@kgeller kgeller requested a review from rylnd May 23, 2022 17:33
@kgeller kgeller removed the 8.4.0 label Jun 28, 2022
@kgeller kgeller marked this pull request as draft July 5, 2022 18:36
@kgeller kgeller marked this pull request as ready for review July 5, 2022 18:48
@kgeller kgeller requested review from ebeahan and peasead July 5, 2022 18:48
@kgeller kgeller added the 8.5.0 label Jul 5, 2022
peasead
peasead approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@peasead peasead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're mainly removing the beta comments.

LGTM.

rylnd
rylnd approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the followup here @kgeller !

@kgeller kgeller merged commit 643076a into elastic:main Jul 19, 2022
@kgeller kgeller deleted the threat-enrichments-indicator-reuses-ga branch July 19, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

@peasead peasead peasead approved these changes

@ebeahan ebeahan Awaiting requested review from ebeahan

Assignees

@kgeller kgeller

Labels
8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgeller @rylnd @peasead @djptek