Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stage 0/1] Initial draft for IO fieldset RFC #1956

Merged
merged 13 commits into from
Aug 16, 2022

Conversation

mitodrummer
Copy link
Contributor

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? n/a
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. yes
  • Have you added an entry to the CHANGELOG.next.md? no

@mitodrummer mitodrummer requested a review from a team as a code owner June 13, 2022 20:15
@ebeahan ebeahan added the RFC label Jun 30, 2022
fd removed. kprobe nor ebpf can get this info.

Update rfcs/text/0033-tty-output.md

Co-authored-by: Mattia Meleleo <[email protected]>

io fieldset removed in favor of new fields in process fieldset instead. per line timestamp removed. io.source added

updates

more updates to md file

formatting

typo

grammar

more updates to md file

fix
@mitodrummer mitodrummer force-pushed the tty_output_rfc_stage_1 branch from 344a8a4 to 8c63285 Compare July 6, 2022 21:40
@mitodrummer mitodrummer requested a review from lrishi July 6, 2022 21:42
@mitodrummer mitodrummer requested review from ebeahan, lrishi and mmat11 July 14, 2022 21:07
@mitodrummer mitodrummer requested a review from qcorporation July 19, 2022 15:59
Copy link

@m-sample m-sample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested tightening of the descriptive text. Otherwise this looks great and reflects exactly what we discussed.

Copy link

@m-sample m-sample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @mitodrummer. Nice work.

@mitodrummer
Copy link
Contributor Author

@ebeahan This PR should be ready to move to the next stage.

@kgeller
Copy link
Contributor

kgeller commented Aug 15, 2022

@mitodrummer this looks great.

Before merge, could you update your folder to 0035 since that's the RFC number?

@mitodrummer
Copy link
Contributor Author

@mitodrummer this looks great.

Before merge, could you update your folder to 0035 since that's the RFC number?

Done!

What stage do we go to next? I don't think there will be any further updates afaik. Let me know if I need to open up another PR. TY!

@kgeller
Copy link
Contributor

kgeller commented Aug 15, 2022

@mitodrummer what do you think about putting it this to stage 2? Then the fields can be added as beta, just like the linux event model RFC. And then down the line when you're sure it's not going to change, we can move to stage 3 and remove the beta tags.

@mitodrummer
Copy link
Contributor Author

@mitodrummer what do you think about putting it this to stage 2? Then the fields can be added as beta, just like the linux event model RFC. And then down the line when you're sure it's not going to change, we can move to stage 3 and remove the beta tags.

Sounds good to me. Did you need me to update the stage/date in the md file before I merge?

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitodrummer mitodrummer merged commit c2ad241 into elastic:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants