-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stage 0/1] Initial draft for IO fieldset RFC #1956
[Stage 0/1] Initial draft for IO fieldset RFC #1956
Conversation
fd removed. kprobe nor ebpf can get this info. Update rfcs/text/0033-tty-output.md Co-authored-by: Mattia Meleleo <[email protected]> io fieldset removed in favor of new fields in process fieldset instead. per line timestamp removed. io.source added updates more updates to md file formatting typo grammar more updates to md file fix
344a8a4
to
8c63285
Compare
…f single "wildcard" field type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested tightening of the descriptive text. Otherwise this looks great and reflects exactly what we discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @mitodrummer. Nice work.
@ebeahan This PR should be ready to move to the next stage. |
@mitodrummer this looks great. Before merge, could you update your folder to |
Done! What stage do we go to next? I don't think there will be any further updates afaik. Let me know if I need to open up another PR. TY! |
@mitodrummer what do you think about putting it this to stage 2? Then the fields can be added as beta, just like the linux event model RFC. And then down the line when you're sure it's not going to change, we can move to stage 3 and remove the beta tags. |
Sounds good to me. Did you need me to update the stage/date in the md file before I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
make test
? n/amake
and committed those changes? n/a