Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define initial set of field expected_values #1962

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 21, 2022

Summary

Define the expected_values parameter added in #1952.

This set of fields already defined expected or recommended values in the field descriptions.

Updated fields

  • dns.header_flags
  • faas.trigger.type
  • network.direction
  • os.type
  • threat.enrichments.indicator.type
  • threat.enrichments.indicator.confidence
  • threat.enrichments.indicator.marking.tlp
  • threat.indicator.type
  • threat.indicator.confidence
  • threat.indicator.marking.tlp
  • threat.software.platforms
  • threat.software.type

Other changes

  • Correct example from White to WHITE on threat.enrichments.indicator.marking.tlp.

@ebeahan ebeahan added the 8.4.0 label Jun 21, 2022
@ebeahan ebeahan requested a review from a team as a code owner June 21, 2022 14:50
@ebeahan ebeahan self-assigned this Jun 21, 2022
@ebeahan
Copy link
Member Author

ebeahan commented Jun 21, 2022

I realized a changelog.next entry is missing for #1952. Adding one alongside an entry for this PR in 8fb2efc

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit 97584d4 into elastic:main Jun 23, 2022
@ebeahan ebeahan deleted the initial-round-expected_values branch June 23, 2022 20:42
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 23, 2022
* define expected_values and adjust descriptions accordingly

* update artifacts

* changelog

(cherry picked from commit 97584d4)

# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@ebeahan
Copy link
Member Author

ebeahan commented Jun 23, 2022

💚 All backports created successfully

Status Branch Result
8.4

Questions ?

Please refer to the Backport tool documentation

ebeahan added a commit that referenced this pull request Jun 24, 2022
* define expected_values and adjust descriptions accordingly

* update artifacts

* changelog

(cherry picked from commit 97584d4)
mitodrummer pushed a commit to mitodrummer/ecs that referenced this pull request Jul 6, 2022
* define expected_values and adjust descriptions accordingly

* update artifacts

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants