Adding service.node.roles #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Thanks for updating this! Noticed one typo & one thing we changed in the Kibana PR, otherwise LGTM.
cc @kobelb
|
The origin/target part is unfamiliar to me. Are we adding that just to maintain parity with where |
these were already added see e.g. #1916 this PR only superceeds the single-valued |
|
Oh right! I forgot about the generation step. |
Co-authored-by: Luke Elmers <[email protected]>
kgeller
added a commit
to kgeller/ecs
that referenced
this pull request
Jul 6, 2022
# Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
kgeller
added a commit
that referenced
this pull request
Jul 6, 2022
mitodrummer
pushed a commit
to mitodrummer/ecs
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the plural
service.node.rolesfield per #1965@lukeelmers / @matschaffer let me know if you want any tweaks to the description. I mostly kept what you had for the singlular.