Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspell macos fix #1993

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Misspell macos fix #1993

merged 6 commits into from
Jul 12, 2022

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Jul 8, 2022

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? Y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. Y
  • Have you added an entry to the CHANGELOG.next.md? TBC

@djptek djptek requested a review from a team as a code owner July 8, 2022 10:24
@djptek djptek marked this pull request as draft July 8, 2022 10:26
@djptek djptek marked this pull request as ready for review July 8, 2022 10:48
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djptek djptek merged commit 094252d into elastic:main Jul 12, 2022
@djptek djptek deleted the misspell_macos_fix branch July 12, 2022 15:50
@kgeller kgeller added the 8.5.0 label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants