Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC Stage-2] Process IO events #2031

Merged
merged 15 commits into from
Aug 30, 2022
Merged

[RFC Stage-2] Process IO events #2031

merged 15 commits into from
Aug 30, 2022

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Aug 17, 2022 •
edited
Loading

Updates the schemas/process.yml with the new process.io fields.

There is also two new fields that weren't in stage 1 added to track terminal window size.
-process.tty.rows
-process.tty.columns

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? yes
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? yes
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. yes
  • Have you added an entry to the CHANGELOG.next.md? yes

Karl Godard added 2 commits August 17, 2022 11:47
rfc 0035 fields added to schema as beta fields. Also, added two new f…
dc59ce8 
…ields to the process.tty object for tracking terminal window size
generator.py artifacts
1b9839f
@mitodrummer mitodrummer requested a review from m-sample August 17, 2022 19:01
@mitodrummer mitodrummer requested a review from a team as a code owner August 17, 2022 19:01
@mitodrummer
Copy link
Contributor Author

pinging @m-sample. I've added rows/columns to the process.tty field. Let me know if the descriptions are apt.

m-sample
m-sample approved these changes Aug 29, 2022
View reviewed changes
Copy link

@m-sample m-sample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Karl.

@mitodrummer mitodrummer requested a review from kgeller August 29, 2022 20:23
kgeller
kgeller approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitodrummer mitodrummer merged commit e2107b7 into elastic:main Aug 30, 2022
@kgeller kgeller mentioned this pull request Aug 30, 2022
Merged
kgeller pushed a commit to kgeller/ecs that referenced this pull request Aug 30, 2022
@mitodrummer @kgeller
[RFC Stage-2] Process IO events (elastic#2031)
76f2c8d 
* rfc 0035 fields added to schema as beta fields. Also, added two new fields to the process.tty object for tracking terminal window size

* generator.py artifacts

* changelog file updated

* more build artifacts

* renamed lines to rows

* rebuilt

* cleanup

* cleanup

* field rename consistency

Co-authored-by: Karl Godard <[email protected]>
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
#	rfcs/text/0035-tty-output.md
#	rfcs/text/0035/process.yml
kgeller added a commit that referenced this pull request Aug 30, 2022
@kgeller
[RFC Stage-2] Process IO events (#2031) (#2045)
6495b47
@kgeller kgeller mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

@m-sample m-sample m-sample approved these changes

Assignees
No one assigned
Labels
8.5.0 RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitodrummer @kgeller @m-sample