Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed type of process.env_vars to show shadowing #2038

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Changed type of process.env_vars to show shadowing #2038

merged 3 commits into from
Aug 25, 2022

Conversation

Tacklebox
Copy link
Contributor

@Tacklebox Tacklebox commented Aug 24, 2022 •
edited by lrishi
Loading

Updated the type of process.env_vars to be an array of string keywords
to support shadowed variables, i.e. duplicated names with different
values.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

Epic: https://github.com/elastic/security-team/issues/4135

@Tacklebox Tacklebox requested a review from a team as a code owner August 24, 2022 17:21
@Tacklebox @lrishi
Changed type of process.env_vars to show shadowing
b43431c 
Updated the type of process.env_vars to be an array of string keywords
to support shadowed variables, i.e. duplicated names with different
values.
@Tacklebox @lrishi
updated CHANGELOG.next.md
af6d9b3
@lrishi lrishi force-pushed the mborden/process_env_var_capture branch from adcb394 to af6d9b3 Compare August 24, 2022 17:35
mitodrummer
mitodrummer approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@mitodrummer mitodrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tacklebox Tacklebox merged commit ad61000 into main Aug 25, 2022
@lrishi lrishi deleted the mborden/process_env_var_capture branch August 26, 2022 00:59
@kgeller kgeller mentioned this pull request Aug 26, 2022
Merged
kgeller pushed a commit to kgeller/ecs that referenced this pull request Aug 26, 2022
@Tacklebox @kgeller
Changed type of process.env_vars to show shadowing (elastic#2038)
338761f 
* Changed type of process.env_vars to show shadowing

Updated the type of process.env_vars to be an array of string keywords
to support shadowed variables, i.e. duplicated names with different
values.

* updated CHANGELOG.next.md

Co-authored-by: Kylie Geller <[email protected]>
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
kgeller added a commit that referenced this pull request Aug 26, 2022
@kgeller
Changed type of process.env_vars to show shadowing (#2038) (#2043)
71885ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

@mitodrummer mitodrummer mitodrummer approved these changes

@lrishi lrishi Awaiting requested review from lrishi

@m-sample m-sample Awaiting requested review from m-sample

@nfritts nfritts Awaiting requested review from nfritts

@nick-alayil nick-alayil Awaiting requested review from nick-alayil

@DefSecSentinel DefSecSentinel Awaiting requested review from DefSecSentinel

Assignees
No one assigned
Labels
8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tacklebox @kgeller @mitodrummer