Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refining the addition of the risk.* fields locations #2058

Merged
merged 9 commits into from
Sep 28, 2022
Merged

Refining the addition of the risk.* fields locations #2058

merged 9 commits into from
Sep 28, 2022

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 22, 2022 •
edited
Loading

Cleaning up the nestings of the risk.* fields, so that they are only at host.* and user.*

Removing the following:

  • client.user.risk
  • destination.user.risk
  • server.user.risk
  • source.user.risk
  • user.changes.risk
  • user.effective.risk
  • user.target.risk

@kgeller kgeller added bug Something isn't working needs_backport 8.5.0 labels Sep 22, 2022
@kgeller kgeller self-assigned this Sep 22, 2022
@kgeller kgeller marked this pull request as ready for review September 22, 2022 17:29
@kgeller kgeller requested a review from a team as a code owner September 22, 2022 17:29
@kgeller kgeller requested review from rylnd and ajosh0504 September 22, 2022 17:29
@kgeller kgeller changed the title Removing user.risk.* from client, destination, server, and source Refining the addition of the risk.* fields locations Sep 22, 2022
@kgeller kgeller marked this pull request as draft September 22, 2022 17:36
@kgeller kgeller marked this pull request as ready for review September 22, 2022 17:43
ajosh0504
ajosh0504 reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Kylie!

@ajosh0504 ajosh0504 self-requested a review September 27, 2022 17:50
@kgeller kgeller merged commit b4710e1 into elastic:main Sep 28, 2022
@kgeller kgeller deleted the risk-fields-location-correction branch September 28, 2022 18:00
kgeller added a commit to kgeller/ecs that referenced this pull request Sep 28, 2022
@kgeller
Refining the addition of the risk.* fields locations (elastic#2058)
859b48c 
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
#	schemas/subsets/main.yml
@kgeller kgeller mentioned this pull request Sep 28, 2022
Merged
kgeller added a commit to kgeller/ecs that referenced this pull request Sep 28, 2022
@kgeller
Refining the addition of the risk.* fields locations (elastic#2058)
0748b74 
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@kgeller kgeller mentioned this pull request Sep 28, 2022
Merged
kgeller added a commit that referenced this pull request Sep 28, 2022
@kgeller
Refining the addition of the risk.* fields locations (#2058) (#2067)
aa73072
kgeller added a commit that referenced this pull request Sep 28, 2022
@kgeller
Refining the addition of the risk.* fields locations (#2058) (#2068)
03d0034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajosh0504 ajosh0504 ajosh0504 approved these changes

@rylnd rylnd Awaiting requested review from rylnd

Assignees

@kgeller kgeller

Labels
8.5.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgeller @ajosh0504