Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.5] Linux event model GA #2082

Merged
merged 4 commits into from
Nov 1, 2022
Merged

[8.5] Linux event model GA #2082

merged 4 commits into from
Nov 1, 2022

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Oct 19, 2022 •
edited
Loading

Removed beta from the majority of the fields added in 8.2 for RFC 0030.

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? y
  • If submitting code/script changes, have you verified all tests pass locally using make test? y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? y
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. y
  • Have you added an entry to the CHANGELOG.next.md? n

@mitodrummer mitodrummer requested a review from a team as a code owner October 19, 2022 22:24
@mitodrummer mitodrummer changed the title [8.5] Linux event model ga [8.5] Linux event model GA Oct 19, 2022
@mitodrummer mitodrummer requested a review from ebeahan October 20, 2022 14:29
@djptek
Copy link
Contributor

djptek commented Oct 25, 2022

Hi @mitodrummer can we have a CHANGELOG entry similar to e.g.

CHANGELOG.md:* Remove betafromorchestrator field set. #1417

@mitodrummer
Copy link
Contributor Author

Hi @mitodrummer can we have a CHANGELOG entry similar to e.g.

CHANGELOG.md:* Remove betafromorchestrator field set. #1417

Updated, let me know if that entry is sufficient, or if you'd prefer all fields listed which are no longer in beta.

@mitodrummer mitodrummer requested a review from djptek October 25, 2022 18:32
djptek
djptek approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changelog entry

LGTM

@kgeller kgeller merged commit 5f5e409 into elastic:main Nov 1, 2022
@kgeller kgeller mentioned this pull request Nov 1, 2022
Merged
kgeller pushed a commit to kgeller/ecs that referenced this pull request Nov 1, 2022
@mitodrummer @kgeller
[8.5] Linux event model GA (elastic#2082)
272ad63 
# Conflicts:
#	CHANGELOG.next.md
@kgeller kgeller mentioned this pull request Nov 1, 2022
Merged
kgeller pushed a commit to kgeller/ecs that referenced this pull request Nov 1, 2022
@mitodrummer @kgeller
[8.5] Linux event model GA (elastic#2082)
340bd1f
kgeller added a commit that referenced this pull request Nov 1, 2022
@kgeller @mitodrummer
[8.5] Linux event model GA (#2082) (#2088)
71565f9 
# Conflicts:
#	CHANGELOG.next.md

Co-authored-by: Karl Godard <[email protected]>
kgeller added a commit that referenced this pull request Nov 1, 2022
@kgeller
[8.5] [8.5] Linux event model GA (#2082) (#2089)
f19e51a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djptek djptek djptek approved these changes

@ebeahan ebeahan Awaiting requested review from ebeahan

Assignees
No one assigned
Labels
8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitodrummer @djptek @kgeller