Introduce process.executable. #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
Nov 30, 2018
|
There are a few places in Beats that will need changed because we have
|
ruflin
requested changes
Dec 3, 2018
There was a problem hiding this comment.
@andrewkroh To understand what this means from a migration perspective:
- Are these 1-1 mappings that change from 6.x to 7.x? Meaning we could add an alias in 6.x to the renamed field?
- Any other changes?
3 tasks
andrewkroh
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
LGTM.
@ruflin Yeah these would be one-to-one mappings. I think we have a process.exe in 6.x that can be mapped with an alias. And one of my open Packetbeat PRs has a uses process.exe as a new field so that can be updated now.
ruflin
approved these changes
Dec 4, 2018
|
Rebased. |
MikePaquette
pushed a commit
to MikePaquette/ecs-1
that referenced
this pull request
Dec 4, 2018
Also move the more canonical process fields to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that in this PR, I also take the opportunity to move the more important
fields to the top. You may want to review one commit at a time.