Fix type of normalize for process.io.bytes_skipped #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails with AssertionError: 'array' is not an instance of <class 'list'> : process.io.bytes_skipped
andrewkroh
approved these changes
Nov 2, 2022
kgeller
approved these changes
Nov 2, 2022
taylor-swanson
pushed a commit
to taylor-swanson/ecs
that referenced
this pull request
Nov 2, 2022
* Test that normalize fields are always lists Fails with AssertionError: 'array' is not an instance of <class 'list'> : process.io.bytes_skipped * Fix type of normalize for process.io.bytes_skipped * update changelog Co-authored-by: Kylie Geller <[email protected]>
taylor-swanson
pushed a commit
to taylor-swanson/ecs
that referenced
this pull request
Nov 2, 2022
* Test that normalize fields are always lists Fails with AssertionError: 'array' is not an instance of <class 'list'> : process.io.bytes_skipped * Fix type of normalize for process.io.bytes_skipped * update changelog Co-authored-by: Kylie Geller <[email protected]>
taylor-swanson
added a commit
that referenced
this pull request
Nov 2, 2022
* [8.5] Fix type of normalize for process.io.bytes_skipped (#2094) * Test that normalize fields are always lists Fails with AssertionError: 'array' is not an instance of <class 'list'> : process.io.bytes_skipped * Fix type of normalize for process.io.bytes_skipped * update changelog Co-authored-by: Kylie Geller <[email protected]> * Update changelog Co-authored-by: Dan Kortschak <[email protected]> Co-authored-by: Kylie Geller <[email protected]>
taylor-swanson
added a commit
that referenced
this pull request
Nov 2, 2022
* [8.6] Fix type of normalize for process.io.bytes_skipped (#2094) * Test that normalize fields are always lists Fails with AssertionError: 'array' is not an instance of <class 'list'> : process.io.bytes_skipped * Fix type of normalize for process.io.bytes_skipped * update changelog Co-authored-by: Kylie Geller <[email protected]> * Update changelog Co-authored-by: Dan Kortschak <[email protected]> Co-authored-by: Kylie Geller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incorrectly typed
normalizeinprocess.io.bytes_skippedand adds a regression test to prevent this from happening in the future.Please take a look.