-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Extend event.kind allowed values with asset #2178
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cfc0a77
[RFC] Extend event.kind allowed values with asset
taylor-swanson bb93fb5
Update with PR number, other fixes
taylor-swanson 00b3111
Review comments
taylor-swanson be7a29d
Move to stage 2, add scope of impact and concerns sections
taylor-swanson ae3c065
Update description
taylor-swanson 9f32dde
Merge branch 'main' into rfc-event-kind-asset
ebeahan 037129a
set date for stage 2 proposal
ebeahan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,164 @@ | ||
# 0038: Extend event.kind allowed values with asset | ||
<!-- Leave this ID at 0000. The ECS team will assign a unique, contiguous RFC number upon merging the initial stage of this RFC. --> | ||
|
||
- Stage: **2 (Candidate)** <!-- Update to reflect target stage. See https://elastic.github.io/ecs/stages.html --> | ||
- Date: **TBD** <!-- The ECS team sets this date at merge time. This is the date of the latest stage advancement. --> | ||
|
||
<!-- | ||
As you work on your RFC, use the "Stage N" comments to guide you in what you should focus on, for the stage you're targeting. | ||
Feel free to remove these comments as you go along. | ||
--> | ||
|
||
<!-- | ||
Stage 0: Provide a high level summary of the premise of these changes. Briefly describe the nature, purpose, and impact of the changes. ~2-5 sentences. | ||
--> | ||
|
||
<!-- | ||
Stage 1: If the changes include field additions or modifications, please create a folder titled as the RFC number under rfcs/text/. This will be where proposed schema changes as standalone YAML files or extended example mappings and larger source documents will go as the RFC is iterated upon. | ||
--> | ||
|
||
<!-- | ||
Stage X: Provide a brief explanation of why the proposal is being marked as abandoned. This is useful context for anyone revisiting this proposal or considering similar changes later on. | ||
--> | ||
|
||
## Fields | ||
|
||
This RFC proposes extending the list of allowed values for `event.kind` with an additional value, `asset`. | ||
|
||
<!-- | ||
Stage 1: Describe at a high level how this change affects fields. Include new or updated yml field definitions for all of the essential fields in this draft. While not exhaustive, the fields documented here should be comprehensive enough to deeply evaluate the technical considerations of this change. The goal here is to validate the technical details for all essential fields and to provide a basis for adding experimental field definitions to the schema. Use GitHub code blocks with yml syntax formatting, and add them to the corresponding RFC folder. | ||
--> | ||
|
||
<!-- | ||
Stage 2: Add or update all remaining field definitions. The list should now be exhaustive. The goal here is to validate the technical details of all remaining fields and to provide a basis for releasing these field definitions as beta in the schema. Use GitHub code blocks with yml syntax formatting, and add them to the corresponding RFC folder. | ||
--> | ||
|
||
## Usage | ||
|
||
We want to represent a catalog of assets where each document represents some type of user or device entity. The `event.kind` field with `asset` value will be used to identity these types of documents. It has also been proposed that we combine this with other fields to have a more exact definition. For example, a user document may have these event fields specified: | ||
|
||
* `event.kind: asset` | ||
* `event.category: [iam]` | ||
* `event.type: [user, info]` | ||
|
||
<!-- | ||
Stage 1: Describe at a high-level how these field changes will be used in practice. Real world examples are encouraged. The goal here is to understand how people would leverage these fields to gain insights or solve problems. ~1-3 paragraphs. | ||
--> | ||
|
||
## Source data | ||
|
||
An example of a user entity document, with `event.kind: asset`: | ||
|
||
```json | ||
{ | ||
"input": { | ||
"type": "entity-analytics" | ||
}, | ||
"@timestamp": "2023-02-23T20:03:17.489Z", | ||
"event": { | ||
"agent_id_status": "verified", | ||
"ingested": "2023-02-23T20:03:18Z", | ||
"provider": "Azure AD", | ||
"kind": "asset", | ||
"action": "user-discovered", | ||
"category": [ | ||
"iam" | ||
], | ||
"type": [ | ||
"user", | ||
"info" | ||
], | ||
"dataset": "entityanalytics_azure.users" | ||
}, | ||
"user": { | ||
"full_name": "Test User", | ||
"phone": [ | ||
"1235559999" | ||
], | ||
"name": [ | ||
"[email protected]" | ||
], | ||
"id": "b3e92fd4-0269-49ae-8a26-812e952bb7ad", | ||
"email": "[email protected]" | ||
}, | ||
"labels": { | ||
"identity_source": "entity-analytics-entityanalytics_azure.users-c1745610-d9a4-437f-a8f8-82ab45ace54a" | ||
} | ||
} | ||
``` | ||
|
||
<!-- | ||
Stage 1: Provide a high-level description of example sources of data. This does not yet need to be a concrete example of a source document, but instead can simply describe a potential source (e.g. nginx access log). This will ultimately be fleshed out to include literal source examples in a future stage. The goal here is to identify practical sources for these fields in the real world. ~1-3 sentences or unordered list. | ||
--> | ||
|
||
<!-- | ||
Stage 2: Included a real world example source document. Ideally this example comes from the source(s) identified in stage 1. If not, it should replace them. The goal here is to validate the utility of these field changes in the context of a real world example. Format with the source name as a ### header and the example document in a GitHub code block with json formatting, or if on the larger side, add them to the corresponding RFC folder. | ||
--> | ||
|
||
<!-- | ||
Stage 3: Add more real world example source documents so we have at least 2 total, but ideally 3. Format as described in stage 2. | ||
--> | ||
|
||
## Scope of impact | ||
|
||
<!-- | ||
Stage 2: Identifies scope of impact of changes. Are breaking changes required? Should deprecation strategies be adopted? Will significant refactoring be involved? Break the impact down into: | ||
* Ingestion mechanisms (e.g. beats/logstash) | ||
* Usage mechanisms (e.g. Kibana applications, detections) | ||
* ECS project (e.g. docs, tooling) | ||
The goal here is to research and understand the impact of these changes on users in the community and development teams across Elastic. 2-5 sentences each. | ||
--> | ||
|
||
We expect to use the `asset` value within the security solution consistently across asset management, external asset integrations, and persisting related metadata. This field may be further leveraged in o11y topology work as they also are exploring ways to extend the asset.* fields within ECS. | ||
|
||
## Concerns | ||
|
||
<!-- | ||
Stage 1: Identify potential concerns, implementation challenges, or complexity. Spend some time on this. Play devil's advocate. Try to identify the sort of non-obvious challenges that tend to surface later. The goal here is to surface risks early, allow everyone the time to work through them, and ultimately document resolution for posterity's sake. | ||
--> | ||
|
||
<!-- | ||
Stage 2: Document new concerns or resolutions to previously listed concerns. It's not critical that all concerns have resolutions at this point, but it would be helpful if resolutions were taking shape for the most significant concerns. | ||
--> | ||
|
||
<!-- | ||
Stage 3: Document resolutions for all existing concerns. Any new concerns should be documented along with their resolution. The goal here is to eliminate risk of churn and instability by ensuring all concerns have been addressed. | ||
--> | ||
|
||
There are no breaking changes identified. There are no other concerns to note at this time. | ||
|
||
## People | ||
|
||
The following are the people that consulted on the contents of this RFC. | ||
|
||
* @taylor-swanson | author | ||
* @SourinPaul | sponsor | ||
* @MikePaquette | sponsor | ||
|
||
<!-- | ||
Who will be or has been consulted on the contents of this RFC? Identify authorship and sponsorship, and optionally identify the nature of involvement of others. Link to GitHub aliases where possible. This list will likely change or grow stage after stage. | ||
|
||
e.g.: | ||
|
||
* @Yasmina | author | ||
* @Monique | sponsor | ||
* @EunJung | subject matter expert | ||
* @JaneDoe | grammar, spelling, prose | ||
* @Mariana | ||
--> | ||
|
||
|
||
## References | ||
|
||
<!-- Insert any links appropriate to this RFC in this section. --> | ||
|
||
### RFC Pull Requests | ||
|
||
<!-- An RFC should link to the PRs for each of it stage advancements. --> | ||
|
||
* Stage 0-2: https://github.com/elastic/ecs/pull/2178 | ||
|
||
<!-- | ||
* Stage 1: https://github.com/elastic/ecs/pull/NNN | ||
... | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Licensed to Elasticsearch B.V. under one or more contributor | ||
# license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright | ||
# ownership. Elasticsearch B.V. licenses this file to you under | ||
# the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
--- | ||
- name: event | ||
title: Event | ||
group: 2 | ||
short: Fields breaking down the event details. | ||
description: > | ||
The event fields are ... # Omitted for brevity | ||
type: group | ||
|
||
fields: | ||
- name: kind | ||
level: core | ||
type: keyword | ||
short: The kind of the event. The highest categorization field in the hierarchy. | ||
description: > | ||
This is one of four ECS ... # Omitted for brevity | ||
example: alert | ||
allowed_values: | ||
- name: asset | ||
description: > | ||
This value indicates events whose primary purpose is to store an inventory of | ||
assets/entities and their attributes. Assets/entities are objects (such as | ||
users and hosts) that are expected to be subjects of detailed analysis within | ||
the system. | ||
|
||
Examples include lists of user identities or accounts ingested from directory | ||
services such as Active Directory (AD), inventory of hosts pulled from | ||
configuration management databases (CMDB), and lists of cloud storage buckets | ||
pulled from cloud provider API's. | ||
|
||
This value is used by Elastic Security for asset management solutions. | ||
`event.kind: asset` is not used for normal system events or logs that are coming | ||
from an asset/entity, nor is it used for system events or logs coming from a | ||
directory or CMDB system. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the final (stage 3) version, it may be nice to have examples for other entities included here for completeness, like groups and devices, if those definitions are finalized at that point.