Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Faas fields - stage 2 - change faas.trigger type from nested to object #2194

Merged
merged 6 commits into from
Apr 28, 2023
Merged

[RFC] Faas fields - stage 2 - change faas.trigger type from nested to object #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e18d4e0
change faas.trigger type from nested to object
gsantoro Apr 6, 2023
9b0c331
removed faas.trigger altogether
gsantoro Apr 11, 2023
faf5b12
Merge branch 'main' into faas-stage-2.1
gsantoro Apr 11, 2023
d01feb8
Merge branch 'main' into faas-stage-2.1
gsantoro Apr 13, 2023
a049970
added changelog
gsantoro Apr 13, 2023
cc1a07c
Merge remote-tracking branch 'origin/main' into faas-stage-2.1
felixbarny Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Thanks, you're awesome :-) -->
#### Improvements

#### Deprecated
* Removed `faas.trigger: nested` since we only have one trigger. #2194

### Tooling and Artifact Changes

Expand Down
16 changes: 0 additions & 16 deletions docs/fields/field-details.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3928,22 +3928,6 @@ type: keyword

example: `my-function`

| extended

// ===============================================================

|
[[field-faas-trigger]]
<<field-faas-trigger, faas.trigger>>

a| Details about the function trigger.

type: nested





| extended

// ===============================================================
Expand Down
5 changes: 0 additions & 5 deletions experimental/generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,11 +2697,6 @@
description: The name of a serverless function.
example: my-function
default_field: false
- name: trigger
level: extended
type: nested
description: Details about the function trigger.
default_field: false
- name: trigger.request_id
level: extended
type: keyword
Expand Down
1 change: 0 additions & 1 deletion experimental/generated/csv/fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
8.9.0-dev+exp,true,faas,faas.execution,keyword,extended,,af9d5aa4-a685-4c5f-a22b-444f80b3cc28,The execution ID of the current function execution.
8.9.0-dev+exp,true,faas,faas.id,keyword,extended,,arn:aws:lambda:us-west-2:123456789012:function:my-function,The unique identifier of a serverless function.
8.9.0-dev+exp,true,faas,faas.name,keyword,extended,,my-function,The name of a serverless function.
8.9.0-dev+exp,true,faas,faas.trigger,nested,extended,,,Details about the function trigger.
8.9.0-dev+exp,true,faas,faas.trigger.request_id,keyword,extended,,123456789,"The ID of the trigger request , message, event, etc."
8.9.0-dev+exp,true,faas,faas.trigger.type,keyword,extended,,http,The trigger for the function execution.
8.9.0-dev+exp,true,faas,faas.version,keyword,extended,,123,The version of a serverless function.
Expand Down
9 changes: 0 additions & 9 deletions experimental/generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3794,15 +3794,6 @@ faas.name:
normalize: []
short: The name of a serverless function.
type: keyword
faas.trigger:
dashed_name: faas-trigger
description: Details about the function trigger.
flat_name: faas.trigger
level: extended
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
9 changes: 0 additions & 9 deletions experimental/generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4813,15 +4813,6 @@ faas:
normalize: []
short: The name of a serverless function.
type: keyword
faas.trigger:
dashed_name: faas-trigger
description: Details about the function trigger.
flat_name: faas.trigger
level: extended
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
3 changes: 1 addition & 2 deletions experimental/generated/elasticsearch/composable/component/faas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"ignore_above": 1024,
"type": "keyword"
}
},
"type": "nested"
}
},
"version": {
"ignore_above": 1024,
Expand Down
3 changes: 1 addition & 2 deletions experimental/generated/elasticsearch/legacy/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,8 +1327,7 @@
"ignore_above": 1024,
"type": "keyword"
}
},
"type": "nested"
}
},
"version": {
"ignore_above": 1024,
Expand Down
5 changes: 0 additions & 5 deletions generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2647,11 +2647,6 @@
description: The name of a serverless function.
example: my-function
default_field: false
- name: trigger
level: extended
type: nested
description: Details about the function trigger.
default_field: false
- name: trigger.request_id
level: extended
type: keyword
Expand Down
1 change: 0 additions & 1 deletion generated/csv/fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
8.9.0-dev,true,faas,faas.execution,keyword,extended,,af9d5aa4-a685-4c5f-a22b-444f80b3cc28,The execution ID of the current function execution.
8.9.0-dev,true,faas,faas.id,keyword,extended,,arn:aws:lambda:us-west-2:123456789012:function:my-function,The unique identifier of a serverless function.
8.9.0-dev,true,faas,faas.name,keyword,extended,,my-function,The name of a serverless function.
8.9.0-dev,true,faas,faas.trigger,nested,extended,,,Details about the function trigger.
8.9.0-dev,true,faas,faas.trigger.request_id,keyword,extended,,123456789,"The ID of the trigger request , message, event, etc."
8.9.0-dev,true,faas,faas.trigger.type,keyword,extended,,http,The trigger for the function execution.
8.9.0-dev,true,faas,faas.version,keyword,extended,,123,The version of a serverless function.
Expand Down
9 changes: 0 additions & 9 deletions generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3725,15 +3725,6 @@ faas.name:
normalize: []
short: The name of a serverless function.
type: keyword
faas.trigger:
dashed_name: faas-trigger
description: Details about the function trigger.
flat_name: faas.trigger
level: extended
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
9 changes: 0 additions & 9 deletions generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4733,15 +4733,6 @@ faas:
normalize: []
short: The name of a serverless function.
type: keyword
faas.trigger:
dashed_name: faas-trigger
description: Details about the function trigger.
flat_name: faas.trigger
level: extended
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
3 changes: 1 addition & 2 deletions generated/elasticsearch/composable/component/faas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"ignore_above": 1024,
"type": "keyword"
}
},
"type": "nested"
}
},
"version": {
"ignore_above": 1024,
Expand Down
3 changes: 1 addition & 2 deletions generated/elasticsearch/legacy/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,8 +1285,7 @@
"ignore_above": 1024,
"type": "keyword"
}
},
"type": "nested"
}
},
"version": {
"ignore_above": 1024,
Expand Down
5 changes: 0 additions & 5 deletions schemas/faas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@
type: keyword
level: extended
example: "af9d5aa4-a685-4c5f-a22b-444f80b3cc28"
- name: trigger
level: extended
type: nested
description: >
Details about the function trigger.
- name: trigger.type
level: extended
type: keyword
Expand Down