Re-introduce http precisely as it was, as of #d8cece6
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePaquette
reviewed
Dec 5, 2018
schemas/http.yml
Outdated
| title: HTTP | ||
| group: 2 | ||
| description: > | ||
| Fields related to HTTP requests and responses. |
There was a problem hiding this comment.
A minor issue, but I'd suggest broadening the definition to something like. Fields related to HTTP activity. (Since, for example, http.version is not technically a request or a response.)
Otherwise, LGTM
MikePaquette
approved these changes
Dec 5, 2018
ruflin
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is strictly to re-introduce the `http` field set as it was, not to work on enhancements to the field set. Those enhancements belong into separate PRs.
We've decided to leave http at the top level for the inaugural release of ECS. We are still considering nesting all protocol breakdowns eventually, but this will come at a later date.
This reverts #171