Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for synthetic_source_keep = none #2422

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Jan 14, 2025

Add support for synthetic_source_keep mapping in generated elasticsearch component files, and add this mapping field to all ECS fields that represent sets.

synthetic_source_keep = none indicates that field is an unordered set, and helps improve storage efficiency with Elasticsearch logsdb index mode.

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? y
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. y
  • Have you added an entry to the CHANGELOG.next.md? y

Add support for synthetic_source_keep mapping in generated elasticsearch
component files. synthetic_source_keep = none indicates that field is an
unordered set, and helps improve effiecency with synthetic source.
For all ECS fields that represent a set, add synthetic_source_keep = "none"
@mjwolf mjwolf marked this pull request as ready for review January 15, 2025 22:37
@mjwolf mjwolf requested a review from a team as a code owner January 15, 2025 22:37
@mjwolf mjwolf self-assigned this Jan 15, 2025
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjwolf mjwolf merged commit 442a1c6 into elastic:main Jan 17, 2025
3 checks passed
mjwolf added a commit to mjwolf/ecs that referenced this pull request Jan 17, 2025
…2422)

Add support for synthetic_source_keep mapping in generated elasticsearch component files, and add this mapping field to all ECS fields that represent sets.

synthetic_source_keep = none indicates that field is an unordered set, and helps improve storage efficiency with Elasticsearch logsdb index mode.
mjwolf added a commit that referenced this pull request Jan 21, 2025
…2425)

Add support for synthetic_source_keep mapping in generated elasticsearch component files, and add this mapping field to all ECS fields that represent sets.

synthetic_source_keep = none indicates that field is an unordered set, and helps improve storage efficiency with Elasticsearch logsdb index mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants