Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Stage 0: Introduce Entity Field Set into ECS #2434
[RFC] Stage 0: Introduce Entity Field Set into ECS #2434
Changes from all commits
5ceb23b
ebb691c
47951c9
4b62cbc
d2fa67a
1fc6cff
cf37d70
d86df7b
6e77f67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should be more concretely defined. It seems like
"the most stable and commonly used identifier"
could be subjective, and different implementors could different values for the same entity. I think it might be better if this listed a preferred order of IDs to use, and state the highest priority type that's known must be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @mjwolf. While I don't think it will be feasible to come up with a comprehensive priority list of preferred IDs for all possible entity data sources/types, I agree we should be more concrete.
I'll update the documentation to include specific examples for common entity types. For instance:
This should help guide implementors while still allowing flexibility for entity types we haven't explicitly covered. What do you think? cc @romulets @maxcold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! I think having one preferred id in the documentation itself is better than what it's right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this breakdown, since it answers a lot of questions that keep popping up. Especially stuff like GCP, where there isn't a one defined ARN-like format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good! I will incorporate this "guidance" into the subsequent stages of the RFC process 👍🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be just replaced by
event.module
? Could you define exactly how they are different