Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Stage 2: Introducing new fields in file/dll/process fields #2441

Merged
merged 15 commits into from
Feb 7, 2025

Conversation

AsuNa-jp
Copy link
Contributor

@AsuNa-jp AsuNa-jp commented Feb 3, 2025

  • Have you signed the contributor license agreement?
    Yes
  • Have you followed the contributor guidelines?
    Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
    Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
    Yes
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
    Yes
  • Have you added an entry to the CHANGELOG.next.md?
    Yes

@AsuNa-jp AsuNa-jp changed the title [RFC] Stage 2: Introducing new fields in file/dll/process fieldscreate a draft [RFC] Stage 2: Introducing new fields in file/dll/process fields Feb 3, 2025
@AsuNa-jp AsuNa-jp marked this pull request as ready for review February 4, 2025 08:02
@AsuNa-jp AsuNa-jp requested a review from a team as a code owner February 4, 2025 08:02
@elastic elastic deleted a comment from github-actions bot Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@elastic elastic deleted a comment from github-actions bot Feb 4, 2025
@mjwolf
Copy link
Contributor

mjwolf commented Feb 5, 2025

@AsuNa-jp Can you add a changelog entry in CHANGELOG.next.md?

@elastic elastic deleted a comment from github-actions bot Feb 5, 2025
@elastic elastic deleted a comment from github-actions bot Feb 5, 2025
@elastic elastic deleted a comment from github-actions bot Feb 5, 2025
@elastic elastic deleted a comment from github-actions bot Feb 5, 2025
@elastic elastic deleted a comment from github-actions bot Feb 5, 2025
@AsuNa-jp
Copy link
Contributor Author

AsuNa-jp commented Feb 5, 2025

Hi @mjwolf
Thank you very much for the feedback. I've added changelog entry to CHANGELOG.next.md and added beta: This field is beta and subject to change. to all of the newly added fields.

I also added an example of how file origin information is added when downloading a file from a web browser on macOS. Let me know if you need additional examples.

For process.executable see my reply at #2441 (comment)

Copy link

github-actions bot commented Feb 7, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@mjwolf mjwolf merged commit 9347ad0 into elastic:main Feb 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants