Change url.port datatype to long #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for @ruflin's return on this one. Not sure if we should backport to 1.0. |
|
Tagging for backport anyway, to make sure we don't forget about it. |
|
Duplicate of #274 🙂 |
|
🤦♂️ |
ruflin
approved these changes
Mar 5, 2019
webmat
added a commit
to webmat/ecs
that referenced
this pull request
Mar 5, 2019
This was referenced Mar 5, 2019
webmat
added a commit
to webmat/ecs
that referenced
this pull request
Mar 5, 2019
webmat
pushed a commit
to webmat/beats
that referenced
this pull request
Mar 11, 2019
A consequence of elastic/ecs#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This discrepancy was noticed when I replaced the Go template generator with a
new one, in #336. Looks like the Beats generator was making the field
longeven if the definition said
integer.