Backport #379 to 1.0: Generate full Beats field definitions, including nested fields (#379) #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncluding nested fields (elastic#379) Backport of PR elastic#379 to 1.0 branch. Original message: This work has revealed a subtle bug in the generated files schema.csv and both ES templates, which were missing the group fieldset in all places where user is reused. (e.g. `host.user.group.*`) Upon comparing this new file to the fields definition file we had handcrafted for Beats (prior to this), it also revealed we had missed a few things in the Beats field definitions: - We had forgotten to define the reusable `user` fieldset `client`, `destination`, `server` and `source`. They previously had been missed. - We had forgotten to define the reusable `geo` fieldset at `host.geo.*` and `observer.geo.*`
webmat
pushed a commit
to webmat/beats
that referenced
this pull request
Mar 8, 2019
No harm was done to the fields between 1.0 and master
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #379 to 1.0 branch. Original message:
This work has revealed a subtle bug in the generated files schema.csv and both
ES templates, which were missing the group fieldset in all places where user
is reused. (e.g.
host.user.group.*)Upon comparing this new file to the fields definition file we had handcrafted for Beats (prior to this), it also revealed we had missed a few things in the Beats field definitions:
userfieldsetclient,destination,serverandsource. They previously had been missed.geofieldset athost.geo.*andobserver.geo.*