Take 2 of readme reset PR #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@webmat Ok if I start reviewing when the others are merged? |
added 7 commits
March 25, 2019 14:55
- point to the official docs - point to contributor-centric documentation
|
@ruflin This is ready for final review. You can even try both links. The ECS docs are live ;-) |
webmat
added a commit
to webmat/ecs
that referenced
this pull request
Mar 26, 2019
…oc (elastic#400) * readme no longer contains the field definitions * readme now directs people to the main website, for the official ECS documentation * Introduce `make legacy_use_cases` to generate the use cases (they were previously generated at the same time as the readme) * Document generated files a bit * contributing guidelines now point people to a page in the docs, to reduce content duplication * renamed the two intermediary in memory representations to match the variable names used in the code
webmat
added a commit
that referenced
this pull request
Mar 27, 2019
…tributor-centric doc (#405) * readme no longer contains the field definitions * readme now directs people to the main website, for the official ECS documentation * Introduce `make legacy_use_cases` to generate the use cases (they were previously generated at the same time as the readme) * Document generated files a bit * contributing guidelines now point people to a page in the docs, to reduce content duplication * renamed the two intermediary in memory representations to match the variable names used in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun facts:
In this PR (other than dep. PR):
TODO
Release
Last minute adjustments needed on this PR, once the ECS docs are pushed to the website.