Adjust make targets for docs to use docker/asciidoctor #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's how the main website docs for ECS are generated nowadays :-) |
|
Lgtm!
…On Wed, Apr 17, 2019, 16:41 Mathieu Martin ***@***.***> wrote:
@webmat <https://github.com/webmat> requested your review on: #435
<#435> Adjust make targets to use
docker/asciidoctor..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#435 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AABUXIWOR5GQBIIVUY44K4LPQ6DOFANCNFSM4HGXTY7Q>
.
|
ruflin
approved these changes
Apr 18, 2019
webmat
changed the title
webmat
changed the title
webmat
added a commit
to webmat/ecs
that referenced
this pull request
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main site generation recently switched to the new & improved docker/asciidoctor setup via elastic/docs#813