-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added domain field to user #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I agree this makes total sense.
I have two small tweaks I would like to request, and then we're good to merge.
Implemented changes as proposed. |
The field description in all the files is based on what's in |
Sorry, forgot this! Just pushed the commited build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thomaspatzke Thanks for your contribution :-) |
And of course I thought "oh wait, what about the Changelog" one millisecond after merging 😂 |
No description provided.