Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added domain field to user #486

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Added domain field to user #486

merged 3 commits into from
Jun 27, 2019

Conversation

thomaspatzke
Copy link
Contributor

No description provided.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I agree this makes total sense.

I have two small tweaks I would like to request, and then we're good to merge.

@thomaspatzke
Copy link
Contributor Author

Implemented changes as proposed.

@webmat
Copy link
Contributor

webmat commented Jun 26, 2019

The field description in all the files is based on what's in schemas/*.yml. Please run make generate to re-generate all other files. That's why the build is breaking :-)

@thomaspatzke
Copy link
Contributor Author

Sorry, forgot this! Just pushed the commited build.

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat
Copy link
Contributor

webmat commented Jun 27, 2019

@thomaspatzke Thanks for your contribution :-)

@webmat webmat merged commit 2e66452 into elastic:master Jun 27, 2019
@webmat
Copy link
Contributor

webmat commented Jun 27, 2019

And of course I thought "oh wait, what about the Changelog" one millisecond after merging 😂

webmat pushed a commit to webmat/ecs that referenced this pull request Jun 27, 2019
webmat pushed a commit that referenced this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants