Clarify service.id description.
#502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an example that went contrary to the purpose of a `service.id`. If someone needs to focus on the events emitted by one host of a service, they should filter on `host.id` or `host.name`. `service.id` is meant to identify a service as a whole.
|
I think this clarifies it, WDYT @axw? |
MikePaquette
approved these changes
Jul 19, 2019
|
Thanks @webmat, that's 100% clear now. |
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Jul 22, 2019
This removes an example that went contrary to the purpose of a `service.id`. If someone needs to focus on the events emitted by one host of a service, they should filter on `host.id` or `host.name`. `service.id` is meant to identify a service as a whole.
webmat
pushed a commit
that referenced
this pull request
Jul 22, 2019
This removes an example that went contrary to the purpose of a `service.id`. If someone needs to focus on the events emitted by one host of a service, they should filter on `host.id` or `host.name`. `service.id` is meant to identify a service as a whole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an example that went contrary to the purpose of a
service.id.If someone needs to focus on the events emitted by one host of a
service, they should filter on
host.idorhost.name.service.idis meant to identify a service as a whole.