Added registered_domain to client, server, source, destination, url #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client.registered_domain destination.registered_domain server.registered_domain source.registered_domain url.registered_domain
Set to to extended by mistake. Changes domain back to core
mbudge
force-pushed
the
registered_domain
branch
from
735345b to
26d9aa4
Compare
webmat
suggested changes
Aug 30, 2019
schemas/url.yml
Outdated
| @@ -44,7 +44,7 @@ | |||
| example: https | |||
|
|
|||
| - name: domain | |||
| level: extended | |||
| level: core | |||
There was a problem hiding this comment.
The whole url field set is extended; url.domain should remain extended.
|
@mbudge Thanks for the changes! Only thing left is |
Changed url.domain back to extended
mbudge
force-pushed
the
registered_domain
branch
from
a44e9b6 to
1306a96
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the following fields so users can find connections to the top level registered domain, even if there is a subdomain.
Currently uses have to add a custom keyword field if they want to search malware.com and also find connections to foo.malware.com.
client.registered_domain
destination.registered_domain
server.registered_domain
source.registered_domain
url.registered_domain
The registered_domain field conforms with the existing dns.registered_domain field.