Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added process.args_count #615

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Added process.args_count #615

merged 5 commits into from
Nov 22, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 18, 2019

In ECS we genrally try to avoid adding counts fields for arrays, if the count
will only be used for display purposes.
This can be calculated on the fly by the consumer, or via a scripted field.

This case is different, however. Following the premise that a process requiring
more arguments may be more suspect than a process started with very few arguments,
then creating analysis content or performing searches for args_count > N becomes
valuable.

cc @rw-access @randomuserid

@webmat webmat self-assigned this Nov 18, 2019
Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've used things like this before
process.name:"powershell.exe" and command_line:"* *" to infer that it was executed with additional arguments.

That was inefficient, so switching to process.name:"powershell.exe" and process.args_count:>1 will help performance significantly.

@webmat webmat merged commit 89955c6 into elastic:master Nov 22, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Nov 25, 2019
webmat pushed a commit that referenced this pull request Nov 25, 2019
dcode pushed a commit to dcode/ecs that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants