Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out the csv a little #621

Merged
merged 9 commits into from
Nov 25, 2019
Merged

Flesh out the csv a little #621

merged 9 commits into from
Nov 25, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 21, 2019

In this PR:

  • Add the field set column
  • Add the short description
  • Add whether the field should be indexed
  • Reorder the columns a bit, so the stable length values are first

Preview GitHub's rendering of generated/csv/fields.csv (scroll right for definitions)

@webmat webmat self-assigned this Nov 21, 2019
@webmat
Copy link
Contributor Author

webmat commented Nov 21, 2019

cc @MikePaquette :-)

@MikePaquette
Copy link
Contributor

Looks great @webmat !

@webmat webmat merged commit 5888af8 into elastic:master Nov 25, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Nov 26, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Nov 26, 2019
webmat pushed a commit that referenced this pull request Nov 26, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Nov 26, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Nov 26, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Nov 26, 2019
dcode pushed a commit to dcode/ecs that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants