Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema.json and the code that generates it #627

Merged
merged 5 commits into from
Nov 26, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 22, 2019

This file is no longer used to power the SIEM field browser.

@webmat webmat self-assigned this Nov 22, 2019
@webmat webmat added the cleanup label Nov 22, 2019
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful to remove such file as I would argue if someone else uses these, it is a breaking change. Not to the schema, but to our tooling.

@webmat
Copy link
Contributor Author

webmat commented Nov 25, 2019

Its creator didn't even end up using it 🤷‍♂

@ruflin
Copy link
Contributor

ruflin commented Nov 25, 2019

🤦‍♂ That doesn't mean someone else is using it. I'm good with this "breaking change" but lets at least have it in the changelog so users know.

@webmat
Copy link
Contributor Author

webmat commented Nov 25, 2019

Yeah, someone else may be using it.

If anyone needs this, please make yourselves heard, even if this PR has already been merged. We can bring it back if needed :-)

@webmat
Copy link
Contributor Author

webmat commented Nov 25, 2019

Move this changelog entry to the tooling section
@pete-otaqui-sky
Copy link

Hi - I'd like to ask for this to be put back in. We'd like to be able to validate ECS compatibility using AWS API Gateway, which depends on JSON Schema. Would you like a PR for putting it back?

@ebeahan
Copy link
Member

ebeahan commented Jul 7, 2020

Hi @pete-otaqui-sky. Currently ECS doesn't maintain a JSON format of the schema as part of the generated artifacts. However, the ecs_nested.yml file is intended to be consumed programmatically and YAML can be painlessly converted to a JSON format if required for your needs.

Please feel free to open a new issue if you'd like to discuss further or have additional questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants