Remove tls.server.supported_ciphers field #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the client, the server can't provide a list of it's supported ciphers in its hello message.
|
@webmat Was this already released? |
|
@ruflin Yes it was. Since it's a field that doesn't make sense, I propose we release ECS 1.3.1 with only this removal in it. @dcode or @dainperkins you guys agree this field doesn't make sense, right? |
|
@ruflin To clarify. During the exchange, the client says which ciphers it supports -- captured at The server picks which one to chose, and the selected cipher should be captured in At no point are there server side "supported ciphers" we can capture. I think this was a copy/pasta mistake ;-) |
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Dec 3, 2019
Unlike the client, the server doesn't provide a list of supported ciphers in its hello message.
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Dec 3, 2019
Unlike the client, the server doesn't provide a list of supported ciphers in its hello message.
webmat
pushed a commit
that referenced
this pull request
Dec 3, 2019
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
Unlike the client, the server doesn't provide a list of supported ciphers in its hello message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the client, the server doesn't provide a list of supported ciphers in its hello message.