-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DLL fieldset #679
Add DLL fieldset #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least changes on removing the comment accidentally copied from schemas/process.yml
into the new definition. The other stuff is more for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think APM should chime in on this as well. @simitt or @graphaelli do you think there would be a need for library.*
as well in APM? Would the semantics proposed here be ok?
Note that we can keep building on this, missing fields wouldn't be a problem.
Another thing to point out here is that typically we break down the file paths that may be suspicious to help with detections, and we have a single field with the full file path whenever the path is more informational and not necessarily suspicious. With that in mind, do you think we should instead nest |
I renamed to DLL to maintain clarity and avoid scope creep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm good with the approach here, I have a few things I'd like to address first, though. See the comments.
Thanks Ross!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these adjustments. I have one further tweak I'd like to discuss, in the phrasing of the field set description, as well as one nitpick.
Don't forget to run make
to re-generate everything, on the last commit.
We can merge after this. It's looking good :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the adjustments!
Closes #675
Added a field set for code libraries/modules, which could be used for DLL loads into a process,
but also for driver loads into the kernel if we go that route.I think those should go in a separate field set.dll.*
chosen as the name, but I'm willing to change it for anything better we have in minddll.name
dll.process
PE fields (#676) can also be nested here, as well as
hash.*
. That'll likely happen in a PR that solves PE, or in this one, depending on which is done first.