Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beats: Set default_field=false in multi_fields #717

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jan 8, 2020

The generator was not adding default_field: false to multi_fields. This again causes Beats to exceed the number of fields in the default list due to the recent addition of some multi_fields.

This will add the tag to multifields that are not in the whitelist and whose parent field is in the whitelist. If the parent field is not in the whitelist, the tag is already inherited.

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr You only need this backported to 1.4, correct?

@webmat webmat merged commit c6a88fc into elastic:master Jan 8, 2020
webmat pushed a commit to webmat/ecs that referenced this pull request Jan 8, 2020
@adriansr
Copy link
Contributor Author

adriansr commented Jan 8, 2020

Yes, only 1.4. Thanks

adriansr added a commit that referenced this pull request Jan 8, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Jan 10, 2020
adriansr added a commit to elastic/beats that referenced this pull request Jan 10, 2020
- Update vendored elastic/ecs and fields.ecs.yml from ECS 1.4 branch

Includes elastic/ecs#717 and  elastic/ecs#687 not in released v1.4.0

- Remove field `process.exit_code` from Metricbeat, now in ECS.
adriansr added a commit to adriansr/beats that referenced this pull request Jan 13, 2020
- Update vendored elastic/ecs and fields.ecs.yml from ECS 1.4 branch

Includes elastic/ecs#717 and  elastic/ecs#687 not in released v1.4.0

- Remove field `process.exit_code` from Metricbeat, now in ECS.

(cherry picked from commit cab56a3)
adriansr added a commit to elastic/beats that referenced this pull request Jan 14, 2020
- Update vendored elastic/ecs and fields.ecs.yml from ECS 1.4 branch

Includes elastic/ecs#717 and  elastic/ecs#687 not in released v1.4.0

- Remove field `process.exit_code` from Metricbeat, now in ECS.

(cherry picked from commit cab56a3)
dcode pushed a commit to dcode/ecs that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants