Fix bug with subsets and reusable fields #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be updated to fix a related bug - now if you apply a subset operation to reusables in one place then the reusable is modified in all places. I think the right solution is to allow reusables to be subsetted independently in each location where they are reused, which means doing the subset operation after the reusables are converted from references to copies in the intermediate structure. I'll update the PR and remove the |
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Apr 7, 2020
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset operation needs to be done after reusables are dropped in place, otherwise reusables could be incorrectly removed by the subset operation. i.e. if
hashis not included in the subset at the top level, then it won't show up atprocess.hasheven ifprocess.*is included in the subset.