-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event.reference field #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog :-)
In all other places where we have URLs pointing to reference docs, the fields are called .reference
. However, since this field is specifically not made to point to reference docs, I wonder if we should name this one .reference
?
To give an example, if someone wants to add reference URLs to their Windows events, event.reference
would sound like the field to put the link to the Microsoft docs, when in fact it's not. And this example also demonstrates that we could have a conflict, if someone wants to add a link to the event itself in AD (the intended use for this field), as well as the reference URL to their events.
WDYT?
@webmat good observations.
Yes, this will be the first use of
I had been thinking that this field could be used for either a static link to docs or an active link. However, you raise the point of what to do if both are desired. One idea is to recommend ECS Can we leverage (and more carefully document) the distinction between For now, I've enhanced the definition of this new field |
@MikePaquette Any time we give a dual purpose to a field, the two purposes should be mutually exclusive (e.g. similar concepts on Linux and Windows), where both definitions couldn't be applicable at the same time. This is not the case here. We need two fields, for situations where both a link to generic reference documentation and a link to a specific instance of an event/alert are applicable. Perhaps we can simply achieve this with an additional field called
I believe the current pressing need is not for the reference-type URL, but for the link to a specific instance, correct? If that's the case, I'm ok with either adjusting this PR to address only We need to home in on a name quickly, if we want this in ECS 1.5.0. |
Quoting @MikePaquette from elsewhere
I know in general we avoid creating fields with the same name as existing field sets. However I don't think this is a case we need to be worried about. My thinking is that a full So if you like the name |
thanks @webmat I added new field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the addition of event.url
.
I'll make the two small typo fixes noted below and merge.
schemas/event.yml
Outdated
@@ -549,7 +549,19 @@ | |||
description: > | |||
Reference URL linking to additional information about this event. | |||
|
|||
This URL can link to either a static definition of the general event, or to another | |||
This URL links to a static definition of the this event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL links to a static definition of the this event | |
This URL links to a static definition of the this event. |
schemas/event.yml
Outdated
type: keyword | ||
short: Event investigation URL | ||
description: > | ||
URL linking to an external system to continue investigtion of this event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL linking to an external system to continue investigtion of this event. | |
URL linking to an external system to continue investigation of this event. |
ECS already has a
rule.reference
field to contain a reference URL to additional information about a rule used to generate an event/alert. The URL can point to the vendor’s documentation about the rule, or if that’s not available, it can also be a link to a more general page describing this type of alert.However some systems provide not only a reference to the rule that created the event, but also to the specific instance of the event or alert itself.
This URL can link to another system where additional or in-depth investigation the specific occurrence of this event can take place. Alert events, indicated by
event.kind:alert
, are a common use case for this field.example: https://mysystem.mydomain.com/alert/5271dedb-f5b0-4218-87f0-4ac4870a38fe
This new field
event.reference
is for storing such URL's.