-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify event.kind definitions re: vulnerabilities #758
Clarify event.kind definitions re: vulnerabilities #758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement @MikePaquette
A few requests:
- Please add a changelog entry :-)
- Remove additional mention of vulnerability reports as metrics (see comment)
- Discussion: could we find better examples for
event.kind:state
? (see comment) - Discussion: I think we should address head on the fact that there can be state transition events (cluster went from green to red) and state info events (every minute: cluster is still green).
- I think there was discussion that state transitions should be
event.kind:event
and state info should beevent.kind:state
. - Although I'm not sure I like the approach in the point above. I think all state events should be in
event.kind:state
, and whether it's a transition or an informational update should be determined via another field.
- I think there was discussion that state transitions should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of potential areas for clarification, might just be me being overly esoteric
During a review of the ECS categorization fields, it was noticed that the examples given for
event.kind:"metric"
were actually a better fit forevent.kind:"state"
This PR clarifies both definitions.
No ECS fields or values are changed with this PR.
Thanks @dainperkins for noticing this.