-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network category and related types #761
Conversation
Are we putting flow to be under connection? Or would that be dependent on event.kind? |
I think we should add "allowed" and "denied" to category "authentication" as well. WDYT? |
authentication should be success, failure - allowed/denied is authorization (which iirc we are typically reporting on under the resource that access was attempted on - e.g. file access allowed / denied) |
@dainperkins re:
Not sure what you mean by "flow" in that question, but indeed anything that would be included in flow analysis would have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small formatting change required. Otherwise I think we're good!
schemas/event.yml
Outdated
description: > | ||
The denied event type is used for the subset of events within a category that | ||
indicate that something was denied. Common examples include | ||
`event.category:”network” AND event.type:denied` (to indicate a network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to always use straight quotes, not the fancy ones Google Docs and the others use.
`event.category:”network” AND event.type:denied` (to indicate a network | |
`event.category:"network" AND event.type:denied` (to indicate a network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to tweak the formatting but the content otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some minor comments (on the wrong/generated file).
This PR adds a new value of event.category:"network" and the corresponding values of
event.type
to be able to represent all network events and metrics in ECS.event.category:"network"
event.type:"allowed"
event.type:"denied"
event.type:"connection"
event.type:"protocol"