-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent.build for extended agent version information #764
Conversation
@james-elastic Would this be useful to the Endpoint team? Does someone on the team have thoughts about this? |
When hearing custom build and sha, I rather wonder if it would make sense to have standardized fields, instead of an adhoc string only field. E.g. |
+1 on the idea of having @urso Perhaps an idea is that we go with |
+1 on making What will |
I'm on board starting with |
@webmat yeah this would be very helpful! |
Love the idea of following the @andrewstucki I think we can move swiftly and rename your field addition to Then in later PRs, as needed we can start adding more precise fields. WDYT about this plan? |
@webmat sorry, this totally slipped by--I renamed the field to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good to go with this, when this comment is addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @andrewstucki
@@ -22,6 +22,7 @@ Thanks, you're awesome :-) --> | |||
|
|||
* Added `search.*` fields #729 | |||
* Add architecture and imphash for PE field set. (#763) | |||
* Added `agent.build.*` for extended agent version information. (#764) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added `agent.build.*` for extended agent version information. (#764) | |
* Added `agent.build.original` for extended agent version information. (#764) |
* Add agent.build for extended agent version information * Add changelog entry * rename field to build.original * re-run code generation * Add short field and additional line about formatting
This adds a field for extended build information for agents. This would actually be pretty useful in a few scenarios:
The use case from the endpoint side is in identifying exact build configurations of an endpoint that's shipping data to elasticsearch. When we see a buggy payload we want to be able to identify the exact build of the binary even if semver indicates it's from a particular release branch. I could imagine the same thing would be potentially useful in beats.