registry.data.strings field missing array definition. #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I agree, thanks for raising this :-) I think the PR for Registry was being worked on at the same time as the normalize/array PR. |
|
Generated files were fine. I simply added a bugfix changelog entry. |
|
@codebrain Hey btw please clone the ECS repo, and create your branches & submit your PRs from your fork. We need to limit the branches on the official repo to version branches and the occasional long term experimental branch. But no feature branches here, as much as possible. It creates too much of a mess :-) |
No problem, will do in future. |
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #776
Please re-run generator before approving, thanks!