Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize DNS related fields across entities #797

Closed
wants to merge 6 commits into from
Closed

Normalize DNS related fields across entities #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53a556f
Nomalizae Entoty Domain representation
dainperkins Mar 23, 2020
f83b09a
pr number in changelog.md
dainperkins Mar 23, 2020
1c54d7c
add cc & host
dainperkins Mar 23, 2020
37a6afe
dns.answers fields added
dainperkins Mar 30, 2020
34a2f46
Updated Domain fields
dainperkins Aug 4, 2020
ad994fe
Adjusted DNS answers
dainperkins Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Thanks, you're awesome :-) -->

#### Added

* Added `search.*` fields #729
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for future clarification - when I update from source, I should just add a line to CHANGELOG.next.md?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just add your line and don't touch the rest :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the conflicts with the CHANGELOG.next are still outstanding.

* Added missing fields to normalize DNS-related fields across `dns` (question and answers), `client`, `destination`, `host`, `server`, `source`, and `url` #797

#### Improvements

Expand All @@ -29,9 +29,6 @@ Thanks, you're awesome :-) -->

#### Bugfixes

* Quoted the example for `labels` to avoid YAML interpreting it, and having
slightly different results in different situations. #782

#### Added

#### Improvements
Expand Down
49 changes: 42 additions & 7 deletions code/go/ecs/client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 40 additions & 7 deletions code/go/ecs/destination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 31 additions & 11 deletions code/go/ecs/dns.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 43 additions & 5 deletions code/go/ecs/host.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 42 additions & 7 deletions code/go/ecs/server.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading