Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading wording about multiple IPs in src/dst or cli/srv #804

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Remove misleading wording about multiple IPs in src/dst or cli/srv #804

merged 3 commits into from
Mar 26, 2020

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Mar 25, 2020

These fields are meant to be a single IP, not "one or more" IP addresses.

Closes #786

@webmat webmat self-assigned this Mar 25, 2020
@webmat webmat added the 1.6.0 label Mar 25, 2020
dainperkins
dainperkins approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@dainperkins dainperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@webmat webmat mentioned this pull request Mar 26, 2020
Closed
@webmat webmat merged commit 816ed67 into elastic:master Mar 26, 2020
@webmat webmat mentioned this pull request Mar 26, 2020
Closed
dcode pushed a commit to dcode/ecs that referenced this pull request Apr 15, 2020
@dcode
Remove misleading wording about multiple IPs in src/dst or cli/srv (e…
8c9b007 
…lastic#804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainperkins dainperkins dainperkins approved these changes

Assignees

@webmat webmat

Labels
1.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.5] IP fields missing array definitions
2 participants
@webmat @dainperkins