Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most reusable field sets in ECS are not expected at the root of the documents. As of ECS 1.5.0:
as
code_signature
geo
group
hash
interface
os
pe
user
vlan
Unfortunately, ever since the introduction of reusable fields, these field sets remained defined at the root nonetheless, for some of the generated artifacts.
The official documentation correctly mentions which field sets were expected at the root and which weren't. This issue however affected the following artifacts:
This PR does not affect the Beats field definitions for now. Even if they weren't meant to be defined there, we first need confirmation whether they've actually been used.
This PR only fixes the issue for the first 3 artifacts.
Note about 'ecs_nested.yml': this file mixes two types of information. Information about field sets, and information about field definitions. Consumers of this file must make sure to check the attribute
reusable.top_level
. You should skip defining fields at the root for any field sets wherereusable.top_level: false
.