Add option for custom template and mapping settings #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
reviewed
May 21, 2020
webmat
approved these changes
May 21, 2020
scripts/generator.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| import os | |||
| import schema_reader | |||
| import yaml | |||
| import json | |||
There was a problem hiding this comment.
Nit: Please remove this new import, as it's no longer needed :-)
ebeahan
approved these changes
May 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little quality of life improvement that lets users override the default template and mapping settings for the generated ES templates. This PR adds 2 new options,
template-settingsandmapping-settingsthat take in filenames and use those json files to populate the template and mapping settings of the generated ES template.Example usage, run in the ECS directory:
python scripts/generator.py --mapping-settings custom_mapping.json --template-settings custom_template.jsonThis replaces the mapping and template settings with whatever is in custom_mapping.json and custom_template.json, respectively.