-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use appropriate reserved domain for example URLs #910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you looked at some of the other places where they may show up, like url and source/dest/client/server?
I noted the other places using real domains:
While it's top of mind, should we unify all of our example usages to |
Yeah if you're up for it 👍 I guess we may have to make a few adjustments outside of these domains per se, for the examples to continue making sense. Example for
Out of the ones you've outlined, I think I would leave |
Whenever you work on some of these domains, make sure to adjust the domain breakdowns as well. |
@webmat this is ready for another 👀 Should we plan on backporting these changes to 1.5? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only remaining domain we could adjust is on server.subject
, where we have "www.mydomain.com". Could you adjust it as well in the same way?
Yeah I think it makes sense to backport this to 1.5. Note that if Beats wants to reimport our field defs to adjust some of the examples that come from ECS, we'd have to cut 1.5.1. But unless this is clearly needed, I think we can simply backport to 1.5 for now, and at least have the main docs corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # CHANGELOG.next.md # docs/field-details.asciidoc # generated/beats/fields.ecs.yml # generated/csv/fields.csv # generated/ecs/ecs_flat.yml # generated/ecs/ecs_nested.yml # schemas/event.yml # schemas/x509.yml
Summary
Two minor documentation changes for the
event.*
field set:Removed the "live" URL links by adding quotes to the string.This is actually incorrect. Our documentation generator is handling this by always wrapping example strings with backticks (`). As long as we ensure the examples don't use potentially valid domains, I don't think we need to worry about being "defensive" for other doc locations which may render a hyperlink for the URLs (e.g. Beats).Switched example URLs to use the IANA reserved
*.example.com