Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1password] - Update ECS to 8.8.0 and pkg-spec 2.7.0 #6373

Merged
merged 2 commits into from
May 31, 2023
Merged

[1password] - Update ECS to 8.8.0 and pkg-spec 2.7.0 #6373

merged 2 commits into from
May 31, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 30, 2023 •
edited
Loading

What does this PR do?

This updates the 1password integration to ECS 8.8.0. It was referencing elastic/ecs [email protected] and using 8.7.0 in ingest pipelines. The pkg-spec version has also been updated to 2.7.0.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0 packages/1password

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/1password
elastic-package test

Related issues

@taylor-swanson
[1password] - update ECS to 8.8.0 from 8.8.0
11aa8bc 
This updates the 1password integration to ECS 8.8.0.
It was referencing elastic/ecs [email protected] and using 8.8.0 in ingest pipelines.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0packages/1password
@taylor-swanson taylor-swanson self-assigned this May 30, 2023
@elasticmachine
Copy link

elasticmachine commented May 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-30T16:35:05.591+0000

  • Duration: 17 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 90.909% (30/33) 👎 -3.209
Lines 87.888% (283/322) 👎 -5.615
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson changed the title [1password] - update ECS to 8.8.0 and pkg-spec 2.7.0 [1password] - Update ECS to 8.8.0 and pkg-spec 2.7.0 May 30, 2023
@taylor-swanson taylor-swanson marked this pull request as ready for review May 30, 2023 18:07
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 30, 2023 18:07
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the update, but I don't see where the existing version has references to 8.8 in pipelines or to [email protected] as noted in the description.

..s/packages/1password [main] ❯❯❯ rg -Fl '8.8'
img/1password-logo-light-bg.svg

@taylor-swanson
Copy link
Contributor Author

LGTM for the update, but I don't see where the existing version has references to 8.8 in pipelines or to [email protected] as noted in the description.

..s/packages/1password [main] ❯❯❯ rg -Fl '8.8'
img/1password-logo-light-bg.svg

Part of the description was written by the ecs-update tool. I think I ran it twice by accident, but even after reverting, the description was still incorrect. I'll fix it above so it mentions referencing 8.7 previously.

@taylor-swanson taylor-swanson merged commit 7d7a87e into elastic:main May 31, 2023
@taylor-swanson taylor-swanson deleted the pkg-spec-1password branch May 31, 2023 12:59
@elasticmachine
Copy link

Package 1password - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=1password

agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
@taylor-swanson @agithomas
[1password] - Update ECS to 8.8.0 and pkg-spec 2.7.0 (elastic#6373)
d339bd8 
This updates the 1password integration to ECS 8.8.0.
It was referencing elastic/ecs [email protected] and using 8.7.0 in ingest pipelines.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0packages/1password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:1password 1Password
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylor-swanson @elasticmachine @efd6