Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying the docker container to have two processes: ui and background tasks #127223

Closed
wants to merge 13 commits into from
Closed

Modifying the docker container to have two processes: ui and background tasks #127223

wants to merge 13 commits into from

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Mar 8, 2022 •
edited
Loading

I ended up not being able to modify the docker container itself to start the two processes.

The dockerCMD for the cloud image is /app/kibana.sh. Cloud is mounting a volume to /app/ that overwrites the /app/kibana.sh included in the container, and the Cloud kibana.sh calls /usr/share/kibana/bin/kibana. That's why this PR changes bin/kibana to spawn the two processes.

I also thought about changing the CMD to a path that isn't overwritten by Cloud so we'd have full control over the start script, but as far as I can tell, the Cloud allocator is generating the kibana.sh using a templating language based on variables that we don't have access to any other way.

@kobelb kobelb changed the title Modifying the docker file to naively have a tasks sidecar Modifying the docker container to have two processes: ui servicing and background tasks Mar 15, 2022
stevedodson added a commit to stevedodson/kibana-2 that referenced this pull request Mar 16, 2022
@stevedodson
Adding elastic#127223 (2 processes) mod
79c9508
@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 29, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 509 508 -1
uptime 56 49 -7
total -19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb kobelb changed the title Modifying the docker container to have two processes: ui servicing and background tasks Modifying the docker container to have two processes: ui and background tasks Apr 12, 2022
@matschaffer matschaffer mentioned this pull request May 18, 2022
Merged
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
@kobelb kobelb closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:cloud-deploy Create or update a Cloud deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobelb @kibana-ci @tylersmalley